I am a week late to this thread, specifically in relation to the Finkelstein, BDS, two states issue. But for what it's worth, I agree with Keith's critiques above.
I have avidly defended Salaita here in Urbana-Champaign--where he lost his job--for many years, and wrote about that on Mondoweiss. But he is mistaken to bring Finkelstein into his own critique, just as he was when he attacked Finkelstein in Electronic Intifada several years ago.
I must also add that I transcribed Finkelstein's recent comments on these controversial matters, just because I thought it was important for people to be able to read them and to have them in the textual record, rather than just on a youtube video. They are at this link:
I would also note that both Counterpunch and Mondoweiss rejected my submission of this transcript, while Z accepted it. That indicates that there is a common reluctance to address Finkelstein's very serious critique of the BDS movement. That's too bad for the Palestinians, in my view.